iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

wifi: nl80211: relax wdev mutex check in wdev_chandef()

Browse Source 
commit 31177127e067eb73d5ca46ce32a410e41333d42f upstream.

In many cases we might get here from driver code that's
not really set up to care about the locking, and for the
non-MLO cases we really don't care so much about it. So
relax the checking here for now, perhaps we should even
remove it completely since we might not really care if
we point to an invalid link's chandef and can require
the caller to check the link validity first.

Fixes: 7b0a0e3c3a88 ("wifi: cfg80211: do some rework towards MLO link APIs")
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Johannes Berg 2022-06-27 12:49:03 +02:00 committed by Greg Kroah-Hartman
parent 05330210d2
commit d94f6d8453
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
net/wireless/chan.c
View File

@ -1433,7 +1433,17 @@ EXPORT_SYMBOL(cfg80211_any_usable_channels);
struct cfg80211_chan_def *wdev_chandef(struct wireless_dev *wdev,
unsigned int link_id)
{
ASSERT_WDEV_LOCK(wdev);
/*
* We need to sort out the locking here - in some cases
* where we get here we really just don't care (yet)
* about the valid links, but in others we do. But we
* get here with various driver cases, so we cannot
* easily require the wdev mutex.
*/
if (link_id || wdev->valid_links & BIT(0)) {
ASSERT_WDEV_LOCK(wdev);
WARN_ON(!(wdev->valid_links & BIT(link_id)));
}
switch (wdev->iftype) {
case NL80211_IFTYPE_MESH_POINT: