iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

leds: led-core: Fix refcount leak in of_led_get()

Browse Source 
class_find_device_by_of_node() calls class_find_device(), it will take
the reference, use the put_device() to drop the reference when not need
anymore.

Fixes: 699a8c7c4b ("leds: Add of_led_get() and led_put()")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Lee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20221220121807.1543790-1-linmq006@gmail.com
This commit is contained in:
Miaoqian Lin 2022-12-20 16:18:07 +04:00 committed by Lee Jones
parent d8960dfb9d
commit da1afe8e60
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/leds/led-class.c
View File

@ -253,6 +253,7 @@ struct led_classdev *of_led_get(struct device_node *np, int index)
led_dev = class_find_device_by_of_node(leds_class, led_node); led_dev = class_find_device_by_of_node(leds_class, led_node);
of_node_put(led_node); of_node_put(led_node);
put_device(led_dev);
return led_module_get(led_dev); return led_module_get(led_dev);
} }