iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

time: Change the return type of clockevents_notify() to integer

Browse Source 
The broadcast framework can potentially be made use of by archs which do not have an
external clock device as well. Then, it is required that one of the CPUs need
to handle the broadcasting of wakeup IPIs to the CPUs in deep idle. As a
result its local timers should remain functional all the time. For such
a CPU, the BROADCAST_ENTER notification has to fail indicating that its clock
device cannot be shutdown. To make way for this support, change the return
type of tick_broadcast_oneshot_control() and hence clockevents_notify() to
indicate such scenarios.

Signed-off-by: Preeti U Murthy <preeti@linux.vnet.ibm.com>
Cc: deepthi@linux.vnet.ibm.com
Cc: paulmck@linux.vnet.ibm.com
Cc: fweisbec@gmail.com
Cc: paulus@samba.org
Cc: srivatsa.bhat@linux.vnet.ibm.com
Cc: svaidy@linux.vnet.ibm.com
Cc: peterz@infradead.org
Cc: benh@kernel.crashing.org
Cc: rafael.j.wysocki@intel.com
Cc: linuxppc-dev@lists.ozlabs.org
Link: http://lkml.kernel.org/r/20140207080606.17187.78306.stgit@preeti.in.ibm.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
This commit is contained in:
Preeti U Murthy 2014-02-07 13:36:06 +05:30 committed by Thomas Gleixner
parent fe79a9ba11
commit da7e6f45c3
4 changed files with 15 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
include/linux/clockchips.h
View File

@ -186,9 +186,9 @@ static inline int tick_check_broadcast_expired(void) { return 0; }
#endif #endif
#ifdef CONFIG_GENERIC_CLOCKEVENTS #ifdef CONFIG_GENERIC_CLOCKEVENTS
extern void clockevents_notify(unsigned long reason, void *arg); extern int clockevents_notify(unsigned long reason, void *arg);
#else #else
static inline void clockevents_notify(unsigned long reason, void *arg) {} static inline int clockevents_notify(unsigned long reason, void *arg) { return 0; }
#endif #endif
#else /* CONFIG_GENERIC_CLOCKEVENTS_BUILD */ #else /* CONFIG_GENERIC_CLOCKEVENTS_BUILD */
@ -196,7 +196,7 @@ static inline void clockevents_notify(unsigned long reason, void *arg) {}
static inline void clockevents_suspend(void) {} static inline void clockevents_suspend(void) {}
static inline void clockevents_resume(void) {} static inline void clockevents_resume(void) {}
static inline void clockevents_notify(unsigned long reason, void *arg) {} static inline int clockevents_notify(unsigned long reason, void *arg) { return 0; }
static inline int tick_check_broadcast_expired(void) { return 0; } static inline int tick_check_broadcast_expired(void) { return 0; }
#endif #endif

8
kernel/time/clockevents.c
View File

@ -542,12 +542,13 @@ void clockevents_resume(void)
#ifdef CONFIG_GENERIC_CLOCKEVENTS #ifdef CONFIG_GENERIC_CLOCKEVENTS
/** /**
* clockevents_notify - notification about relevant events * clockevents_notify - notification about relevant events
* Returns 0 on success, any other value on error
*/ */
void clockevents_notify(unsigned long reason, void *arg) int clockevents_notify(unsigned long reason, void *arg)
{ {
struct clock_event_device *dev, *tmp; struct clock_event_device *dev, *tmp;
unsigned long flags; unsigned long flags;
int cpu; int cpu, ret = 0;
raw_spin_lock_irqsave(&clockevents_lock, flags); raw_spin_lock_irqsave(&clockevents_lock, flags);
@ -560,7 +561,7 @@ void clockevents_notify(unsigned long reason, void *arg)
case CLOCK_EVT_NOTIFY_BROADCAST_ENTER: case CLOCK_EVT_NOTIFY_BROADCAST_ENTER:
case CLOCK_EVT_NOTIFY_BROADCAST_EXIT: case CLOCK_EVT_NOTIFY_BROADCAST_EXIT:
tick_broadcast_oneshot_control(reason); ret = tick_broadcast_oneshot_control(reason);
break; break;
case CLOCK_EVT_NOTIFY_CPU_DYING: case CLOCK_EVT_NOTIFY_CPU_DYING:
@ -603,6 +604,7 @@ void clockevents_notify(unsigned long reason, void *arg)
break; break;
} }
raw_spin_unlock_irqrestore(&clockevents_lock, flags); raw_spin_unlock_irqrestore(&clockevents_lock, flags);
return ret;
} }
EXPORT_SYMBOL_GPL(clockevents_notify); EXPORT_SYMBOL_GPL(clockevents_notify);

6
kernel/time/tick-broadcast.c
View File

@ -646,14 +646,15 @@ again:
/* /*
* Powerstate information: The system enters/leaves a state, where * Powerstate information: The system enters/leaves a state, where
* affected devices might stop * affected devices might stop
* Returns 0 on success, -EBUSY if the cpu is used to broadcast wakeups.
*/ */
void tick_broadcast_oneshot_control(unsigned long reason) int tick_broadcast_oneshot_control(unsigned long reason)
{ {
struct clock_event_device *bc, *dev; struct clock_event_device *bc, *dev;
struct tick_device *td; struct tick_device *td;
unsigned long flags; unsigned long flags;
ktime_t now; ktime_t now;
int cpu; int cpu, ret = 0;
/* /*
* Periodic mode does not care about the enter/exit of power * Periodic mode does not care about the enter/exit of power
@ -759,6 +760,7 @@ void tick_broadcast_oneshot_control(unsigned long reason)
} }
out: out:
raw_spin_unlock_irqrestore(&tick_broadcast_lock, flags); raw_spin_unlock_irqrestore(&tick_broadcast_lock, flags);
return ret;
} }
/* /*

6
kernel/time/tick-internal.h
View File

@ -46,7 +46,7 @@ extern int tick_switch_to_oneshot(void (*handler)(struct clock_event_device *));
extern void tick_resume_oneshot(void); extern void tick_resume_oneshot(void);
# ifdef CONFIG_GENERIC_CLOCKEVENTS_BROADCAST # ifdef CONFIG_GENERIC_CLOCKEVENTS_BROADCAST
extern void tick_broadcast_setup_oneshot(struct clock_event_device *bc); extern void tick_broadcast_setup_oneshot(struct clock_event_device *bc);
extern void tick_broadcast_oneshot_control(unsigned long reason); extern int tick_broadcast_oneshot_control(unsigned long reason);
extern void tick_broadcast_switch_to_oneshot(void); extern void tick_broadcast_switch_to_oneshot(void);
extern void tick_shutdown_broadcast_oneshot(unsigned int *cpup); extern void tick_shutdown_broadcast_oneshot(unsigned int *cpup);
extern int tick_resume_broadcast_oneshot(struct clock_event_device *bc); extern int tick_resume_broadcast_oneshot(struct clock_event_device *bc);
@ -58,7 +58,7 @@ static inline void tick_broadcast_setup_oneshot(struct clock_event_device *bc)
{ {
BUG(); BUG();
} }
static inline void tick_broadcast_oneshot_control(unsigned long reason) { } static inline int tick_broadcast_oneshot_control(unsigned long reason) { return 0; }
static inline void tick_broadcast_switch_to_oneshot(void) { } static inline void tick_broadcast_switch_to_oneshot(void) { }
static inline void tick_shutdown_broadcast_oneshot(unsigned int *cpup) { } static inline void tick_shutdown_broadcast_oneshot(unsigned int *cpup) { }
static inline int tick_broadcast_oneshot_active(void) { return 0; } static inline int tick_broadcast_oneshot_active(void) { return 0; }
@ -87,7 +87,7 @@ static inline void tick_broadcast_setup_oneshot(struct clock_event_device *bc)
{ {
BUG(); BUG();
} }
static inline void tick_broadcast_oneshot_control(unsigned long reason) { } static inline int tick_broadcast_oneshot_control(unsigned long reason) { return 0; }
static inline void tick_shutdown_broadcast_oneshot(unsigned int *cpup) { } static inline void tick_shutdown_broadcast_oneshot(unsigned int *cpup) { }
static inline int tick_resume_broadcast_oneshot(struct clock_event_device *bc) static inline int tick_resume_broadcast_oneshot(struct clock_event_device *bc)
{ {