char: ipmi: constify ipmi_smi_handlers structures
Declare ipmi_smi_handlers structures as const as they are only passed as an argument to the function ipmi_register_smi. This argument is of type const, so ipmi_smi_handlers structures having similar properties can be declared const too. Done using Coccinelle: @r1 disable optional_qualifier@ identifier i; position p; @@ static struct ipmi_smi_handlers i@p={...}; @ok1@ identifier r1.i; position p; @@ ipmi_register_smi(&i@p,...) @bad@ position p!={r1.p,ok1.p}; identifier r1.i; @@ i@p @depends on !bad disable optional_qualifier@ identifier r1.i; @@ +const struct ipmi_smi_handlers i; Size details after cross compiling the .o file for powerpc architecture File size before: text data bss dec hex filename 2777 288 0 3065 bf9 drivers/char/ipmi/ipmi_powernv.o File size after: text data bss dec hex filename 2873 192 0 3065 bf9 drivers/char/ipmi/ipmi_powernv.o Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> Signed-off-by: Corey Minyard <cminyard@mvista.com>
This commit is contained in:
parent
c690d14148
commit
db3b7e1341
@ -196,7 +196,7 @@ static void ipmi_powernv_poll(void *send_info)
|
||||
ipmi_powernv_recv(smi);
|
||||
}
|
||||
|
||||
static struct ipmi_smi_handlers ipmi_powernv_smi_handlers = {
|
||||
static const struct ipmi_smi_handlers ipmi_powernv_smi_handlers = {
|
||||
.owner = THIS_MODULE,
|
||||
.start_processing = ipmi_powernv_start_processing,
|
||||
.sender = ipmi_powernv_send,
|
||||
|
Loading…
Reference in New Issue
Block a user