iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drm/i915: Call i915_globals_exit() if pci_register_device() fails

Browse Source 
In the unlikely event that pci_register_device() fails, we were tearing
down our PMU setup but not globals.  This leaves a bunch of memory slabs
lying around.

Signed-off-by: Jason Ekstrand <jason@jlekstrand.net>
Fixes: 32eb6bcfdda9 ("drm/i915: Make request allocation caches global")
[danvet: Fix conflicts against removal of the globals_flush
infrastructure.]
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20210721152358.2893314-3-jason@jlekstrand.net
This commit is contained in:
Jason Ekstrand 2021-07-21 10:23:54 -05:00 committed by Daniel Vetter
parent 75d3bf84df
commit db484889d1
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/gpu/drm/i915/i915_globals.c
View File

@ -59,7 +59,7 @@ int __init i915_globals_init(void)
return 0;
}
void __exit i915_globals_exit(void)
void i915_globals_exit(void)
{
__i915_globals_cleanup();
}

1
drivers/gpu/drm/i915/i915_pci.c
View File

@ -1195,6 +1195,7 @@ static int __init i915_init(void)
err = pci_register_driver(&i915_pci_driver);
if (err) {
i915_pmu_exit();
i915_globals_exit();
return err;
}