iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

phy: core: make phy_class constant

Browse Source 
Since commit 43a7206b0963 ("driver core: class: make class_register() take
a const *"), the driver core allows for struct class to be in read-only
memory, so move the phy_class structure to be declared at build time
placing it into read-only memory, instead of having to be dynamically
allocated at boot time.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: "Ricardo B. Marliere" <ricardo@marliere.net>
Link: https://lore.kernel.org/r/20240305-class_cleanup-phy-v1-1-106013a644dc@marliere.net
Signed-off-by: Vinod Koul <vkoul@kernel.org>
This commit is contained in:
Ricardo B. Marliere 2024-03-05 15:18:51 -03:00 committed by Vinod Koul
parent 5cee04a836
commit db704bf6dc
1 changed files with 15 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
drivers/phy/phy-core.c
View File

@ -20,7 +20,12 @@
#include <linux/pm_runtime.h> #include <linux/pm_runtime.h>
#include <linux/regulator/consumer.h> #include <linux/regulator/consumer.h>
static struct class *phy_class; static void phy_release(struct device *dev);
static const struct class phy_class = {
.name = "phy",
.dev_release = phy_release,
};
static struct dentry *phy_debugfs_root; static struct dentry *phy_debugfs_root;
static DEFINE_MUTEX(phy_provider_mutex); static DEFINE_MUTEX(phy_provider_mutex);
static LIST_HEAD(phy_provider_list); static LIST_HEAD(phy_provider_list);
@ -753,7 +758,7 @@ struct phy *of_phy_simple_xlate(struct device *dev,
struct phy *phy; struct phy *phy;
struct class_dev_iter iter; struct class_dev_iter iter;
class_dev_iter_init(&iter, phy_class, NULL, NULL); class_dev_iter_init(&iter, &phy_class, NULL, NULL);
while ((dev = class_dev_iter_next(&iter))) { while ((dev = class_dev_iter_next(&iter))) {
phy = to_phy(dev); phy = to_phy(dev);
if (args->np != phy->dev.of_node) if (args->np != phy->dev.of_node)
@ -1016,7 +1021,7 @@ struct phy *phy_create(struct device *dev, struct device_node *node,
device_initialize(&phy->dev); device_initialize(&phy->dev);
mutex_init(&phy->mutex); mutex_init(&phy->mutex);
phy->dev.class = phy_class; phy->dev.class = &phy_class;
phy->dev.parent = dev; phy->dev.parent = dev;
phy->dev.of_node = node ?: dev->of_node; phy->dev.of_node = node ?: dev->of_node;
phy->id = id; phy->id = id;
@ -1285,14 +1290,13 @@ static void phy_release(struct device *dev)
static int __init phy_core_init(void) static int __init phy_core_init(void)
{ {
phy_class = class_create("phy"); int err;
if (IS_ERR(phy_class)) {
pr_err("failed to create phy class --> %ld\n",
PTR_ERR(phy_class));
return PTR_ERR(phy_class);
}
phy_class->dev_release = phy_release; err = class_register(&phy_class);
if (err) {
pr_err("failed to register phy class");
return err;
}
phy_debugfs_root = debugfs_create_dir("phy", NULL); phy_debugfs_root = debugfs_create_dir("phy", NULL);
@ -1303,6 +1307,6 @@ device_initcall(phy_core_init);
static void __exit phy_core_exit(void) static void __exit phy_core_exit(void)
{ {
debugfs_remove_recursive(phy_debugfs_root); debugfs_remove_recursive(phy_debugfs_root);
class_destroy(phy_class); class_unregister(&phy_class);
} }
module_exit(phy_core_exit); module_exit(phy_core_exit);