iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

staging: r8712u: cleanup pointer type in r8712_setassocsta_cmd()

Browse Source 
This seems like a cut and paste bug.  Smatch complains that we don't
allocate enough memory for a set_stakey_rsp struct.  In fact this is
used as a set_assocsta_rsp struct throughout and that also matches the
name of the function.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Dan Carpenter 2012-10-25 15:30:06 +03:00 committed by Greg Kroah-Hartman
parent e33909c6d4
commit db9d1f6dd2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/staging/rtl8712/rtl871x_cmd.c
View File

@ -814,7 +814,7 @@ u8 r8712_setassocsta_cmd(struct _adapter *padapter, u8 *mac_addr)
struct cmd_priv *pcmdpriv = &padapter->cmdpriv; struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
struct cmd_obj *ph2c; struct cmd_obj *ph2c;
struct set_assocsta_parm *psetassocsta_para; struct set_assocsta_parm *psetassocsta_para;
struct set_stakey_rsp *psetassocsta_rsp = NULL; struct set_assocsta_rsp *psetassocsta_rsp = NULL;
ph2c = (struct cmd_obj *)_malloc(sizeof(struct cmd_obj)); ph2c = (struct cmd_obj *)_malloc(sizeof(struct cmd_obj));
if (ph2c == NULL) if (ph2c == NULL)
@ -825,7 +825,7 @@ u8 r8712_setassocsta_cmd(struct _adapter *padapter, u8 *mac_addr)
kfree((u8 *) ph2c); kfree((u8 *) ph2c);
return _FAIL; return _FAIL;
} }
psetassocsta_rsp = (struct set_stakey_rsp *)_malloc( psetassocsta_rsp = (struct set_assocsta_rsp *)_malloc(
sizeof(struct set_assocsta_rsp)); sizeof(struct set_assocsta_rsp));
if (psetassocsta_rsp == NULL) { if (psetassocsta_rsp == NULL) {
kfree((u8 *)ph2c); kfree((u8 *)ph2c);