iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Coccinelle: misc: Improve the matching of rules

Browse Source 
Currently because of the left associativity of the operators, pattern
IRQF_ONESHOT | flags does not match with the pattern when we have more
than one flag after the disjunction. This eventually results in giving
false positives by the script. This patch eliminates these FPs by
improving the rule.

Signed-off-by: Vaishali Thakkar <vaishali.thakkar@oracle.com>
Signed-off-by: Michal Marek <mmarek@suse.com>
This commit is contained in:
Vaishali Thakkar 2016-11-23 14:16:39 +05:30 committed by Michal Marek
parent 51a5f81079
commit dca24c4544
1 changed files with 23 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
scripts/coccinelle/misc/irqf_oneshot.cocci
View File

@ -15,16 +15,13 @@ virtual org
virtual report
@r1@
expression dev;
expression irq;
expression thread_fn;
expression flags;
expression dev, irq, thread_fn;
position p;
@@
(
request_threaded_irq@p(irq, NULL, thread_fn,
(
flags | IRQF_ONESHOT
IRQF_ONESHOT | ...
|
IRQF_ONESHOT
)
@ -32,21 +29,34 @@ IRQF_ONESHOT
|
devm_request_threaded_irq@p(dev, irq, NULL, thread_fn,
(
flags | IRQF_ONESHOT
IRQF_ONESHOT | ...
|
IRQF_ONESHOT
)
, ...)
)
@depends on patch@
expression dev;
expression irq;
expression thread_fn;
expression flags;
@r2@
expression dev, irq, thread_fn, flags, e;
position p != r1.p;
@@
(
flags = IRQF_ONESHOT | ...
|
flags |= IRQF_ONESHOT | ...
)
... when != flags = e
(
request_threaded_irq@p(irq, NULL, thread_fn, flags, ...);
|
devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, flags, ...);
)
@depends on patch@
expression dev, irq, thread_fn, flags;
position p != {r1.p,r2.p};
@@
(
request_threaded_irq@p(irq, NULL, thread_fn,
(
-0
@ -69,13 +79,13 @@ devm_request_threaded_irq@p(dev, irq, NULL, thread_fn,
)
@depends on context@
position p != r1.p;
position p != {r1.p,r2.p};
@@
*request_threaded_irq@p(...)
@match depends on report || org@
expression irq;
position p != r1.p;
position p != {r1.p,r2.p};
@@
request_threaded_irq@p(irq, NULL, ...)