iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pinctrl: msm: Check for ngpios > MAX_NR_GPIO

Browse Source 
Fail the probe and print a warning if SoC specific drivers have
more GPIOs than there can be accounted for in the static bitmaps.
This should avoid silent corruption/failures in the future.

Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Acked-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Stephen Boyd 2014-03-06 22:44:41 -08:00 committed by Linus Walleij
parent 3525f5556a
commit dcd278b860
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/pinctrl/pinctrl-msm.c
View File

@ -897,10 +897,14 @@ static int msm_gpio_init(struct msm_pinctrl *pctrl)
int ret; int ret;
int i; int i;
int r; int r;
unsigned ngpio = pctrl->soc->ngpios;
if (WARN_ON(ngpio > MAX_NR_GPIO))
return -EINVAL;
chip = &pctrl->chip; chip = &pctrl->chip;
chip->base = 0; chip->base = 0;
chip->ngpio = pctrl->soc->ngpios; chip->ngpio = ngpio;
chip->label = dev_name(pctrl->dev); chip->label = dev_name(pctrl->dev);
chip->dev = pctrl->dev; chip->dev = pctrl->dev;
chip->owner = THIS_MODULE; chip->owner = THIS_MODULE;