iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ASoC: omap: Check regulator enable for DAC on Pandora

Browse Source 
This will probably never fail but it's better style.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Acked-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
This commit is contained in:
Mark Brown 2013-03-02 15:47:55 +08:00
parent 4f224c6124
commit dd194b4846
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sound/soc/omap/omap3pandora.c
View File

@ -80,12 +80,18 @@ static int omap3pandora_hw_params(struct snd_pcm_substream *substream,
static int omap3pandora_dac_event(struct snd_soc_dapm_widget *w, static int omap3pandora_dac_event(struct snd_soc_dapm_widget *w,
struct snd_kcontrol *k, int event) struct snd_kcontrol *k, int event)
{ {
int ret;
/* /*
* The PCM1773 DAC datasheet requires 1ms delay between switching * The PCM1773 DAC datasheet requires 1ms delay between switching
* VCC power on/off and /PD pin high/low * VCC power on/off and /PD pin high/low
*/ */
if (SND_SOC_DAPM_EVENT_ON(event)) { if (SND_SOC_DAPM_EVENT_ON(event)) {
regulator_enable(omap3pandora_dac_reg); ret = regulator_enable(omap3pandora_dac_reg);
if (ret) {
dev_err(w->dapm.dev, "Failed to power DAC: %d\n", ret);
return ret;
}
mdelay(1); mdelay(1);
gpio_set_value(OMAP3_PANDORA_DAC_POWER_GPIO, 1); gpio_set_value(OMAP3_PANDORA_DAC_POWER_GPIO, 1);
} else { } else {