iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

quota: make dquot_quota_sync return errors from ->sync_fs

Browse Source 
Strangely, dquot_quota_sync ignores the return code from the ->sync_fs
call, which means that quotacalls like Q_SYNC never see the error.  This
doesn't seem right, so fix that.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Acked-by: Christian Brauner <brauner@kernel.org>
This commit is contained in:
Darrick J. Wong 2022-01-30 08:53:16 -08:00
parent 5679897eb1
commit dd5532a499
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
fs/quota/dquot.c
View File

@ -690,9 +690,14 @@ int dquot_quota_sync(struct super_block *sb, int type)
/* This is not very clever (and fast) but currently I don't know about /* This is not very clever (and fast) but currently I don't know about
* any other simple way of getting quota data to disk and we must get * any other simple way of getting quota data to disk and we must get
* them there for userspace to be visible... */ * them there for userspace to be visible... */
if (sb->s_op->sync_fs) if (sb->s_op->sync_fs) {
sb->s_op->sync_fs(sb, 1); ret = sb->s_op->sync_fs(sb, 1);
sync_blockdev(sb->s_bdev); if (ret)
return ret;
}
ret = sync_blockdev(sb->s_bdev);
if (ret)
return ret;
/* /*
* Now when everything is written we can discard the pagecache so * Now when everything is written we can discard the pagecache so