From de0920b1fedb4d694fe4732cfc3cccfcd4743f84 Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Fri, 23 Sep 2011 09:23:22 +0300 Subject: [PATCH] Staging: vt6655-6: potential info leak in private_ioctl() Smatch has a new check for Rosenberg type information leaks where structs are copied to the user with uninitialized stack data in them. In this path, the .uLinkRate member doesn't get initialized so I've set it to zero. Signed-off-by: Dan Carpenter Signed-off-by: Greg Kroah-Hartman --- drivers/staging/vt6655/ioctl.c | 1 + drivers/staging/vt6656/ioctl.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/staging/vt6655/ioctl.c b/drivers/staging/vt6655/ioctl.c index 8cf88c3b68da..43964a5e72a9 100644 --- a/drivers/staging/vt6655/ioctl.c +++ b/drivers/staging/vt6655/ioctl.c @@ -296,6 +296,7 @@ int private_ioctl(PSDevice pDevice, struct ifreq *rq) { } else { sLinkStatus.bLink = false; + sLinkStatus.uLinkRate = 0; } if (copy_to_user(pReq->data, &sLinkStatus, sizeof(SCmdLinkStatus))) { result = -EFAULT; diff --git a/drivers/staging/vt6656/ioctl.c b/drivers/staging/vt6656/ioctl.c index cfe9c95d7807..1cb9a7d0d883 100644 --- a/drivers/staging/vt6656/ioctl.c +++ b/drivers/staging/vt6656/ioctl.c @@ -291,6 +291,7 @@ int private_ioctl(PSDevice pDevice, struct ifreq *rq) { } else { sLinkStatus.bLink = FALSE; + sLinkStatus.uLinkRate = 0; } if (copy_to_user(pReq->data, &sLinkStatus, sizeof(SCmdLinkStatus))) { result = -EFAULT;