iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

V4L/DVB (12199): remove redundant tests on unsigned

Browse Source 
input, inp and i are unsigned. When negative they are wrapped and caught by the
other test.

Cc: Andy Walls <awalls@radix.net>
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Roel Kluin 2009-07-02 16:09:25 -03:00 committed by Mauro Carvalho Chehab
parent ce27cd3bf9
commit de81c3c3f5
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/media/dvb/ttpci/av7110_v4l.c
View File

@ -490,7 +490,7 @@ static int vidioc_s_input(struct file *file, void *fh, unsigned int input)
if (!av7110->analog_tuner_flags) if (!av7110->analog_tuner_flags)
return 0; return 0;
if (input < 0 || input >= 4) if (input >= 4)
return -EINVAL; return -EINVAL;
av7110->current_input = input; av7110->current_input = input;

2
drivers/media/video/cx18/cx18-ioctl.c
View File

@ -605,7 +605,7 @@ int cx18_s_input(struct file *file, void *fh, unsigned int inp)
if (ret) if (ret)
return ret; return ret;
if (inp < 0 || inp >= cx->nof_inputs) if (inp >= cx->nof_inputs)
return -EINVAL; return -EINVAL;
if (inp == cx->active_input) { if (inp == cx->active_input) {

2
drivers/media/video/saa7134/saa7134-video.c
View File

@ -1790,7 +1790,7 @@ static int saa7134_s_input(struct file *file, void *priv, unsigned int i)
if (0 != err) if (0 != err)
return err; return err;
if (i < 0 || i >= SAA7134_INPUT_MAX) if (i >= SAA7134_INPUT_MAX)
return -EINVAL; return -EINVAL;
if (NULL == card_in(dev, i).name) if (NULL == card_in(dev, i).name)
return -EINVAL; return -EINVAL;