iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

PCI: switchtec: Fix an error handling path in switchtec_pci_probe()

Browse Source 
The commit in Fixes changed the logic on how resources are released and
introduced a new switchtec_exit_pci() that need to be called explicitly in
order to undo a corresponding switchtec_init_pci().

This was done in the remove function, but not in the probe.

Fix the probe now.

Fixes: df25461119d9 ("PCI: switchtec: Fix stdev_release() crash after surprise hot remove")
Link: https://lore.kernel.org/r/01446d2ccb91a578239915812f2b7dfbeb2882af.1703428183.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
This commit is contained in:
Christophe JAILLET 2023-12-24 15:30:01 +01:00 committed by Bjorn Helgaas
parent 6613476e22
commit dec529b0b0
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/pci/switch/switchtec.c
View File

@ -1672,7 +1672,7 @@ static int switchtec_pci_probe(struct pci_dev *pdev,
rc = switchtec_init_isr(stdev); rc = switchtec_init_isr(stdev);
if (rc) { if (rc) {
dev_err(&stdev->dev, "failed to init isr.\n"); dev_err(&stdev->dev, "failed to init isr.\n");
goto err_put; goto err_exit_pci;
} }
iowrite32(SWITCHTEC_EVENT_CLEAR | iowrite32(SWITCHTEC_EVENT_CLEAR |
@ -1693,6 +1693,8 @@ static int switchtec_pci_probe(struct pci_dev *pdev,
err_devadd: err_devadd:
stdev_kill(stdev); stdev_kill(stdev);
err_exit_pci:
switchtec_exit_pci(stdev);
err_put: err_put:
ida_free(&switchtec_minor_ida, MINOR(stdev->dev.devt)); ida_free(&switchtec_minor_ida, MINOR(stdev->dev.devt));
put_device(&stdev->dev); put_device(&stdev->dev);