iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

hwrng: core - remove (un)register_miscdev()

Browse Source 
These functions are redundant after commit 0daa7a0afd0f ("hwrng: Avoid
manual device_create_file() calls").

Let's call misc_(de)register() directly.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Masahiro Yamada 2024-07-06 23:41:24 +09:00 committed by Herbert Xu
parent fe69b772e3
commit df1e979199
1 changed files with 2 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/char/hw_random/core.c
View File

@ -486,16 +486,6 @@ static struct attribute *rng_dev_attrs[] = {
ATTRIBUTE_GROUPS(rng_dev); ATTRIBUTE_GROUPS(rng_dev);
static void __exit unregister_miscdev(void)
{
misc_deregister(&rng_miscdev);
}
static int __init register_miscdev(void)
{
return misc_register(&rng_miscdev);
}
static int hwrng_fillfn(void *unused) static int hwrng_fillfn(void *unused)
{ {
size_t entropy, entropy_credit = 0; /* in 1/1024 of a bit */ size_t entropy, entropy_credit = 0; /* in 1/1024 of a bit */
@ -709,7 +699,7 @@ static int __init hwrng_modinit(void)
return -ENOMEM; return -ENOMEM;
} }
ret = register_miscdev(); ret = misc_register(&rng_miscdev);
if (ret) { if (ret) {
kfree(rng_fillbuf); kfree(rng_fillbuf);
kfree(rng_buffer); kfree(rng_buffer);
@ -726,7 +716,7 @@ static void __exit hwrng_modexit(void)
kfree(rng_fillbuf); kfree(rng_fillbuf);
mutex_unlock(&rng_mutex); mutex_unlock(&rng_mutex);
unregister_miscdev(); misc_deregister(&rng_miscdev);
} }
fs_initcall(hwrng_modinit); /* depends on misc_register() */ fs_initcall(hwrng_modinit); /* depends on misc_register() */