iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

of: unittest: kmemleak in of_unittest_overlay_high_level()

Browse Source 
commit 145fc138f9aae4f9e1331352e301df28e16aed35 upstream.

kmemleak reports several memory leaks from devicetree unittest.
This is the fix for problem 3 of 5.

of_unittest_overlay_high_level() failed to kfree the newly created
property when the property named 'name' is skipped.

Fixes: 39a751a4cb7e ("of: change overlay apply input data from unflattened to FDT")
Reported-by: Erhard F. <erhard_f@mailbox.org>
Signed-off-by: Frank Rowand <frank.rowand@sony.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Frank Rowand 2020-04-16 16:42:48 -05:00 committed by Greg Kroah-Hartman
parent 842f7bbaf4
commit e04087b3f4
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/of/unittest.c
View File

@ -2448,8 +2448,11 @@ static __init void of_unittest_overlay_high_level(void)
goto err_unlock; goto err_unlock;
} }
if (__of_add_property(of_symbols, new_prop)) { if (__of_add_property(of_symbols, new_prop)) {
kfree(new_prop->name);
kfree(new_prop->value);
kfree(new_prop);
/* "name" auto-generated by unflatten */ /* "name" auto-generated by unflatten */
if (!strcmp(new_prop->name, "name")) if (!strcmp(prop->name, "name"))
continue; continue;
unittest(0, "duplicate property '%s' in overlay_base node __symbols__", unittest(0, "duplicate property '%s' in overlay_base node __symbols__",
prop->name); prop->name);