iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fsl/fman: fix the pause_time test

Browse Source 
pause_time is unsigned so it can't be less than zero.  The bug means
that we allow invalid pause-times.

Fixes: 57ba4c9b56d8 ('fsl/fman: Add FMan MAC support')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Dan Carpenter 2016-01-06 12:58:09 +03:00 committed by David S. Miller
parent 719255d0e2
commit e06a03bdf8
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/ethernet/freescale/fman/fman_dtsec.c
View File

@ -934,7 +934,7 @@ int dtsec_set_tx_pause_frames(struct fman_mac *dtsec,
/* FM_BAD_TX_TS_IN_B_2_B_ERRATA_DTSEC_A003 Errata workaround */ /* FM_BAD_TX_TS_IN_B_2_B_ERRATA_DTSEC_A003 Errata workaround */
if (dtsec->fm_rev_info.major == 2) if (dtsec->fm_rev_info.major == 2)
if (pause_time < 0 && pause_time <= 320) { if (pause_time <= 320) {
pr_warn("pause-time: %d illegal.Should be > 320\n", pr_warn("pause-time: %d illegal.Should be > 320\n",
pause_time); pause_time);
return -EINVAL; return -EINVAL;