iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

PCI: cadence: Drop unused member from struct cdns_plat_pcie

Browse Source 
The struct cdns_plat_pcie contains a member called is_rc that is not
being used beyond being assigned a value within the cdns_plat_pcie_probe()
function, which is then not used for anything.

Thus, drop is_rc from the struct cdns_plat_pcie, especially since there
already is an is_rc member within the struct cdns_plat_pcie_of_data that
is actively used to convey information about the PCIe controller mode.

[kwilczynski: commit log]
Signed-off-by: Li Chen <lchen@ambarella.com>
Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
This commit is contained in:
Li Chen 2023-07-05 18:15:51 +08:00 committed by Bjorn Helgaas
parent 0bb80ecc33
commit e111ac7025
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/pci/controller/cadence/pcie-cadence-plat.c
View File

@ -17,12 +17,9 @@
/** /**
* struct cdns_plat_pcie - private data for this PCIe platform driver * struct cdns_plat_pcie - private data for this PCIe platform driver
* @pcie: Cadence PCIe controller * @pcie: Cadence PCIe controller
* @is_rc: Set to 1 indicates the PCIe controller mode is Root Complex,
* if 0 it is in Endpoint mode.
*/ */
struct cdns_plat_pcie { struct cdns_plat_pcie {
struct cdns_pcie *pcie; struct cdns_pcie *pcie;
bool is_rc;
}; };
struct cdns_plat_pcie_of_data { struct cdns_plat_pcie_of_data {
@ -76,7 +73,6 @@ static int cdns_plat_pcie_probe(struct platform_device *pdev)
rc->pcie.dev = dev; rc->pcie.dev = dev;
rc->pcie.ops = &cdns_plat_ops; rc->pcie.ops = &cdns_plat_ops;
cdns_plat_pcie->pcie = &rc->pcie; cdns_plat_pcie->pcie = &rc->pcie;
cdns_plat_pcie->is_rc = is_rc;
ret = cdns_pcie_init_phy(dev, cdns_plat_pcie->pcie); ret = cdns_pcie_init_phy(dev, cdns_plat_pcie->pcie);
if (ret) { if (ret) {
@ -104,7 +100,6 @@ static int cdns_plat_pcie_probe(struct platform_device *pdev)
ep->pcie.dev = dev; ep->pcie.dev = dev;
ep->pcie.ops = &cdns_plat_ops; ep->pcie.ops = &cdns_plat_ops;
cdns_plat_pcie->pcie = &ep->pcie; cdns_plat_pcie->pcie = &ep->pcie;
cdns_plat_pcie->is_rc = is_rc;
ret = cdns_pcie_init_phy(dev, cdns_plat_pcie->pcie); ret = cdns_pcie_init_phy(dev, cdns_plat_pcie->pcie);
if (ret) { if (ret) {