driver core: platform: Add extra error check in devm_platform_get_irqs_affinity()
The current check of nvec < minvec for nvec returned from platform_irq_count() will not detect a negative error code in nvec. This is because minvec is unsigned, and, as such, nvec is promoted to unsigned in that check, which will make it a huge number (if it contained -EPROBE_DEFER). In practice, an error should not occur in nvec for the only in-tree user, but add a check anyway. Fixes: e15f2fa959f2 ("driver core: platform: Add devm_platform_get_irqs_affinity()") Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: John Garry <john.garry@huawei.com> Signed-off-by: Marc Zyngier <maz@kernel.org> Link: https://lore.kernel.org/r/1608561055-231244-1-git-send-email-john.garry@huawei.com
This commit is contained in:
parent
d7f39c40eb
commit
e1dc20995c
@ -351,6 +351,8 @@ int devm_platform_get_irqs_affinity(struct platform_device *dev,
|
||||
return -ERANGE;
|
||||
|
||||
nvec = platform_irq_count(dev);
|
||||
if (nvec < 0)
|
||||
return nvec;
|
||||
|
||||
if (nvec < minvec)
|
||||
return -ENOSPC;
|
||||
|
Loading…
x
Reference in New Issue
Block a user