iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drm/client: Rename drm_client_add() to drm_client_register()

Browse Source 
This is done to stay consistent with our naming scheme of
_register() = others can start calling us from any thread.

Suggested-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20190403125658.32389-1-noralf@tronnes.org
This commit is contained in:
Noralf Trønnes 2019-04-03 14:56:58 +02:00
parent 564d6fd611
commit e33898a207
3 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/gpu/drm/drm_client.c
View File

@ -69,7 +69,8 @@ EXPORT_SYMBOL(drm_client_close);
* @name: Client name * @name: Client name
* @funcs: DRM client functions (optional) * @funcs: DRM client functions (optional)
* *
* This initialises the client and opens a &drm_file. Use drm_client_add() to complete the process. * This initialises the client and opens a &drm_file.
* Use drm_client_register() to complete the process.
* The caller needs to hold a reference on @dev before calling this function. * The caller needs to hold a reference on @dev before calling this function.
* The client is freed when the &drm_device is unregistered. See drm_client_release(). * The client is freed when the &drm_device is unregistered. See drm_client_release().
* *
@ -108,16 +109,16 @@ err_put_module:
EXPORT_SYMBOL(drm_client_init); EXPORT_SYMBOL(drm_client_init);
/** /**
* drm_client_add - Add client to the device list * drm_client_register - Register client
* @client: DRM client * @client: DRM client
* *
* Add the client to the &drm_device client list to activate its callbacks. * Add the client to the &drm_device client list to activate its callbacks.
* @client must be initialized by a call to drm_client_init(). After * @client must be initialized by a call to drm_client_init(). After
* drm_client_add() it is no longer permissible to call drm_client_release() * drm_client_register() it is no longer permissible to call drm_client_release()
* directly (outside the unregister callback), instead cleanup will happen * directly (outside the unregister callback), instead cleanup will happen
* automatically on driver unload. * automatically on driver unload.
*/ */
void drm_client_add(struct drm_client_dev *client) void drm_client_register(struct drm_client_dev *client)
{ {
struct drm_device *dev = client->dev; struct drm_device *dev = client->dev;
@ -125,7 +126,7 @@ void drm_client_add(struct drm_client_dev *client)
list_add(&client->list, &dev->clientlist); list_add(&client->list, &dev->clientlist);
mutex_unlock(&dev->clientlist_mutex); mutex_unlock(&dev->clientlist_mutex);
} }
EXPORT_SYMBOL(drm_client_add); EXPORT_SYMBOL(drm_client_register);
/** /**
* drm_client_release - Release DRM client resources * drm_client_release - Release DRM client resources

2
drivers/gpu/drm/drm_fb_helper.c
View File

@ -3322,7 +3322,7 @@ int drm_fbdev_generic_setup(struct drm_device *dev, unsigned int preferred_bpp)
if (ret) if (ret)
DRM_DEV_DEBUG(dev->dev, "client hotplug ret=%d\n", ret); DRM_DEV_DEBUG(dev->dev, "client hotplug ret=%d\n", ret);
drm_client_add(&fb_helper->client); drm_client_register(&fb_helper->client);
return 0; return 0;
} }

2
include/drm/drm_client.h
View File

@ -90,7 +90,7 @@ struct drm_client_dev {
int drm_client_init(struct drm_device *dev, struct drm_client_dev *client, int drm_client_init(struct drm_device *dev, struct drm_client_dev *client,
const char *name, const struct drm_client_funcs *funcs); const char *name, const struct drm_client_funcs *funcs);
void drm_client_release(struct drm_client_dev *client); void drm_client_release(struct drm_client_dev *client);
void drm_client_add(struct drm_client_dev *client); void drm_client_register(struct drm_client_dev *client);
void drm_client_dev_unregister(struct drm_device *dev); void drm_client_dev_unregister(struct drm_device *dev);
void drm_client_dev_hotplug(struct drm_device *dev); void drm_client_dev_hotplug(struct drm_device *dev);