iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ALSA: control_led - fix initialization in the mode show callback

Browse Source 
The str variable should be always initialized before use even if
the switch covers all cases. This is a minimalistic fix: Assign NULL,
the sprintf() may print '(null)' if something is corrupted.

Signed-off-by: Jaroslav Kysela <perex@perex.cz>
Link: https://lore.kernel.org/r/20210614071710.1786866-1-perex@perex.cz
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Jaroslav Kysela 2021-06-14 09:17:10 +02:00 committed by Takashi Iwai
parent 12c11ba5be
commit e381a14c3e
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sound/core/control_led.c
View File

@ -397,7 +397,7 @@ static ssize_t mode_show(struct device *dev,
struct device_attribute *attr, char *buf) struct device_attribute *attr, char *buf)
{ {
struct snd_ctl_led *led = container_of(dev, struct snd_ctl_led, dev); struct snd_ctl_led *led = container_of(dev, struct snd_ctl_led, dev);
const char *str; const char *str = NULL;
switch (led->mode) { switch (led->mode) {
case MODE_FOLLOW_MUTE: str = "follow-mute"; break; case MODE_FOLLOW_MUTE: str = "follow-mute"; break;