iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

leds: bcm6358: Get rid of custom led_init_default_state_get()

Browse Source 
LED core provides a helper to parse default state from firmware node.
Use it instead of custom implementation.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Lee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20230103131256.33894-6-andriy.shevchenko@linux.intel.com
This commit is contained in:
Andy Shevchenko 2023-01-03 15:12:50 +02:00 committed by Lee Jones
parent 67d162e8bf
commit e41ff81767
1 changed files with 16 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
drivers/leds/leds-bcm6358.c
View File

@ -96,7 +96,8 @@ static int bcm6358_led(struct device *dev, struct device_node *nc, u32 reg,
{ {
struct led_init_data init_data = {}; struct led_init_data init_data = {};
struct bcm6358_led *led; struct bcm6358_led *led;
const char *state; enum led_default_state state;
unsigned long val;
int rc; int rc;
led = devm_kzalloc(dev, sizeof(*led), GFP_KERNEL); led = devm_kzalloc(dev, sizeof(*led), GFP_KERNEL);
@ -110,29 +111,28 @@ static int bcm6358_led(struct device *dev, struct device_node *nc, u32 reg,
if (of_property_read_bool(nc, "active-low")) if (of_property_read_bool(nc, "active-low"))
led->active_low = true; led->active_low = true;
if (!of_property_read_string(nc, "default-state", &state)) { init_data.fwnode = of_fwnode_handle(nc);
if (!strcmp(state, "on")) {
state = led_init_default_state_get(init_data.fwnode);
switch (state) {
case LEDS_DEFSTATE_ON:
led->cdev.brightness = LED_FULL;
break;
case LEDS_DEFSTATE_KEEP:
val = bcm6358_led_read(led->mem + BCM6358_REG_MODE);
val &= BIT(led->pin);
if ((led->active_low && !val) || (!led->active_low && val))
led->cdev.brightness = LED_FULL; led->cdev.brightness = LED_FULL;
} else if (!strcmp(state, "keep")) { else
unsigned long val;
val = bcm6358_led_read(led->mem + BCM6358_REG_MODE);
val &= BIT(led->pin);
if ((led->active_low && !val) ||
(!led->active_low && val))
led->cdev.brightness = LED_FULL;
else
led->cdev.brightness = LED_OFF;
} else {
led->cdev.brightness = LED_OFF; led->cdev.brightness = LED_OFF;
} break;
} else { default:
led->cdev.brightness = LED_OFF; led->cdev.brightness = LED_OFF;
} }
bcm6358_led_set(&led->cdev, led->cdev.brightness); bcm6358_led_set(&led->cdev, led->cdev.brightness);
led->cdev.brightness_set = bcm6358_led_set; led->cdev.brightness_set = bcm6358_led_set;
init_data.fwnode = of_fwnode_handle(nc);
rc = devm_led_classdev_register_ext(dev, &led->cdev, &init_data); rc = devm_led_classdev_register_ext(dev, &led->cdev, &init_data);
if (rc < 0) if (rc < 0)