iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

scsi: ufs: qcom: Check the return value of ufs_qcom_power_up_sequence()

Browse Source 
If ufs_qcom_power_up_sequence() fails, then it makes no sense to enable the
lane clocks and continue ufshcd_hba_enable(). So let's check the return
value of ufs_qcom_power_up_sequence().

Reviewed-by: Andrew Halaney <ahalaney@redhat.com>
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Link: https://lore.kernel.org/r/20231208065902.11006-9-manivannan.sadhasivam@linaro.org
Tested-by: Andrew Halaney <ahalaney@redhat.com> # sa8775p-ride
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Manivannan Sadhasivam
2023-12-08 12:28:53 +05:30
committed by Martin K. Petersen
parent d119547114
commit e430c0e089
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/ufs/host/ufs-qcom.c
View File

@ -417,7 +417,10 @@ static int ufs_qcom_hce_enable_notify(struct ufs_hba *hba,
switch (status) { switch (status) {
case PRE_CHANGE: case PRE_CHANGE:
ufs_qcom_power_up_sequence(hba); err = ufs_qcom_power_up_sequence(hba);
if (err)
return err;
/* /*
* The PHY PLL output is the source of tx/rx lane symbol * The PHY PLL output is the source of tx/rx lane symbol
* clocks, hence, enable the lane clocks only after PHY * clocks, hence, enable the lane clocks only after PHY