iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

platform/chrome: cros_ec_debugfs: Remove dev_warn when console log is not supported

Browse Source 
If the debugfs interface is enabled, every time a CrOS device is
instantiated a warning like this can appear for every probed device.

 "device does not support reading the console log"

The warning message adds nothing, rather it is source of confusion as
this is expected on some cases. For example, on Samus, that has a
cros-ec and a cros-pd instance the message appears twice, and I suspect
this will happen also on those devices that has a non-standard EC.

If the command is not supported just return silently and don't print the
warning, otherwise the code will already print an error.

Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
This commit is contained in:
Enric Balletbo i Serra 2019-04-03 15:47:18 +02:00
parent 8c2ffd9174
commit e43c426a77
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/platform/chrome/cros_ec_debugfs.c
View File

@ -306,11 +306,12 @@ static int cros_ec_create_console_log(struct cros_ec_debugfs *debug_info)
int read_params_size; int read_params_size;
int read_response_size; int read_response_size;
if (!ec_read_version_supported(ec)) { /*
dev_warn(ec->dev, * If the console log feature is not supported return silently and
"device does not support reading the console log\n"); * don't create the console_log entry.
*/
if (!ec_read_version_supported(ec))
return 0; return 0;
}
buf = devm_kzalloc(ec->dev, LOG_SIZE, GFP_KERNEL); buf = devm_kzalloc(ec->dev, LOG_SIZE, GFP_KERNEL);
if (!buf) if (!buf)