iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

usb: typec: anx7411: Use of_get_child_by_name() instead of of_find_node_by_name()

Browse Source 
In anx7411_typec_switch_probe(), we should call of_get_child_by_name()
instead of of_find_node_by_name() as of_find_xxx API will decrease the
refcount of the 'from' argument.

Fixes: fe6d8a9c8e64 ("usb: typec: anx7411: Add Analogix PD ANX7411 support")
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Liang He <windhl@126.com>
Link: https://lore.kernel.org/r/20220915092209.4009273-1-windhl@126.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Liang He 2022-09-15 17:22:09 +08:00 committed by Greg Kroah-Hartman
parent 7489ec86bc
commit e45d7337dc
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/usb/typec/anx7411.c
View File

@ -1105,7 +1105,7 @@ static int anx7411_typec_switch_probe(struct anx7411_data *ctx,
int ret; int ret;
struct device_node *node; struct device_node *node;
node = of_find_node_by_name(dev->of_node, "orientation_switch"); node = of_get_child_by_name(dev->of_node, "orientation_switch");
if (!node) if (!node)
return 0; return 0;
@ -1115,7 +1115,7 @@ static int anx7411_typec_switch_probe(struct anx7411_data *ctx,
return ret; return ret;
} }
node = of_find_node_by_name(dev->of_node, "mode_switch"); node = of_get_child_by_name(dev->of_node, "mode_switch");
if (!node) { if (!node) {
dev_err(dev, "no typec mux exist"); dev_err(dev, "no typec mux exist");
ret = -ENODEV; ret = -ENODEV;