iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

media: imx-jpeg: Fix potential array out of bounds in queue_setup

Browse Source 
Fix smatch warning in mxc_jpeg_queue_setup, check *nplanes against
current format:

drivers/media/platform/imx-jpeg/mxc-jpeg.c:1070
mxc_jpeg_queue_setup()
         warn: potential user controlled iterator 'i' (array size 2 vs 7)

Signed-off-by: Mirela Rabulea <mirela.rabulea@oss.nxp.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
This commit is contained in:
Mirela Rabulea 2022-03-08 14:16:57 +01:00 committed by Mauro Carvalho Chehab
parent ae309657b0
commit e490fa1be5
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
View File

@ -1081,6 +1081,8 @@ static int mxc_jpeg_queue_setup(struct vb2_queue *q,
/* Handle CREATE_BUFS situation - *nplanes != 0 */ /* Handle CREATE_BUFS situation - *nplanes != 0 */
if (*nplanes) { if (*nplanes) {
if (*nplanes != q_data->fmt->colplanes)
return -EINVAL;
for (i = 0; i < *nplanes; i++) { for (i = 0; i < *nplanes; i++) {
if (sizes[i] < q_data->sizeimage[i]) if (sizes[i] < q_data->sizeimage[i])
return -EINVAL; return -EINVAL;