iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

net: ibm: emac: use new api ethtool_{get|set}_link_ksettings

Browse Source 
The ethtool api {get|set}_settings is deprecated.
We move this driver to new api {get|set}_link_ksettings.

Signed-off-by: Philippe Reynes <tremyfr@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Philippe Reynes
2017-01-07 22:32:27 +01:00
committed by David S. Miller
parent cecf62d6c6
commit e4ccf76448
1 changed files with 40 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

70
drivers/net/ethernet/ibm/emac/core.c
View File

@ -1991,69 +1991,79 @@ static struct mal_commac_ops emac_commac_sg_ops = {
}; };
/* Ethtool support */ /* Ethtool support */
static int emac_ethtool_get_settings(struct net_device *ndev, static int emac_ethtool_get_link_ksettings(struct net_device *ndev,
struct ethtool_cmd *cmd) struct ethtool_link_ksettings *cmd)
{ {
struct emac_instance *dev = netdev_priv(ndev); struct emac_instance *dev = netdev_priv(ndev);
u32 supported, advertising;
cmd->supported = dev->phy.features; supported = dev->phy.features;
cmd->port = PORT_MII; cmd->base.port = PORT_MII;
cmd->phy_address = dev->phy.address; cmd->base.phy_address = dev->phy.address;
cmd->transceiver =
dev->phy.address >= 0 ? XCVR_EXTERNAL : XCVR_INTERNAL;
mutex_lock(&dev->link_lock); mutex_lock(&dev->link_lock);
cmd->advertising = dev->phy.advertising; advertising = dev->phy.advertising;
cmd->autoneg = dev->phy.autoneg; cmd->base.autoneg = dev->phy.autoneg;
cmd->speed = dev->phy.speed; cmd->base.speed = dev->phy.speed;
cmd->duplex = dev->phy.duplex; cmd->base.duplex = dev->phy.duplex;
mutex_unlock(&dev->link_lock); mutex_unlock(&dev->link_lock);
ethtool_convert_legacy_u32_to_link_mode(cmd->link_modes.supported,
supported);
ethtool_convert_legacy_u32_to_link_mode(cmd->link_modes.advertising,
advertising);
return 0; return 0;
} }
static int emac_ethtool_set_settings(struct net_device *ndev, static int
struct ethtool_cmd *cmd) emac_ethtool_set_link_ksettings(struct net_device *ndev,
const struct ethtool_link_ksettings *cmd)
{ {
struct emac_instance *dev = netdev_priv(ndev); struct emac_instance *dev = netdev_priv(ndev);
u32 f = dev->phy.features; u32 f = dev->phy.features;
u32 advertising;
ethtool_convert_link_mode_to_legacy_u32(&advertising,
cmd->link_modes.advertising);
DBG(dev, "set_settings(%d, %d, %d, 0x%08x)" NL, DBG(dev, "set_settings(%d, %d, %d, 0x%08x)" NL,
cmd->autoneg, cmd->speed, cmd->duplex, cmd->advertising); cmd->base.autoneg, cmd->base.speed, cmd->base.duplex, advertising);
/* Basic sanity checks */ /* Basic sanity checks */
if (dev->phy.address < 0) if (dev->phy.address < 0)
return -EOPNOTSUPP; return -EOPNOTSUPP;
if (cmd->autoneg != AUTONEG_ENABLE && cmd->autoneg != AUTONEG_DISABLE) if (cmd->base.autoneg != AUTONEG_ENABLE &&
cmd->base.autoneg != AUTONEG_DISABLE)
return -EINVAL; return -EINVAL;
if (cmd->autoneg == AUTONEG_ENABLE && cmd->advertising == 0) if (cmd->base.autoneg == AUTONEG_ENABLE && advertising == 0)
return -EINVAL; return -EINVAL;
if (cmd->duplex != DUPLEX_HALF && cmd->duplex != DUPLEX_FULL) if (cmd->base.duplex != DUPLEX_HALF && cmd->base.duplex != DUPLEX_FULL)
return -EINVAL; return -EINVAL;
if (cmd->autoneg == AUTONEG_DISABLE) { if (cmd->base.autoneg == AUTONEG_DISABLE) {
switch (cmd->speed) { switch (cmd->base.speed) {
case SPEED_10: case SPEED_10:
if (cmd->duplex == DUPLEX_HALF && if (cmd->base.duplex == DUPLEX_HALF &&
!(f & SUPPORTED_10baseT_Half)) !(f & SUPPORTED_10baseT_Half))
return -EINVAL; return -EINVAL;
if (cmd->duplex == DUPLEX_FULL && if (cmd->base.duplex == DUPLEX_FULL &&
!(f & SUPPORTED_10baseT_Full)) !(f & SUPPORTED_10baseT_Full))
return -EINVAL; return -EINVAL;
break; break;
case SPEED_100: case SPEED_100:
if (cmd->duplex == DUPLEX_HALF && if (cmd->base.duplex == DUPLEX_HALF &&
!(f & SUPPORTED_100baseT_Half)) !(f & SUPPORTED_100baseT_Half))
return -EINVAL; return -EINVAL;
if (cmd->duplex == DUPLEX_FULL && if (cmd->base.duplex == DUPLEX_FULL &&
!(f & SUPPORTED_100baseT_Full)) !(f & SUPPORTED_100baseT_Full))
return -EINVAL; return -EINVAL;
break; break;
case SPEED_1000: case SPEED_1000:
if (cmd->duplex == DUPLEX_HALF && if (cmd->base.duplex == DUPLEX_HALF &&
!(f & SUPPORTED_1000baseT_Half)) !(f & SUPPORTED_1000baseT_Half))
return -EINVAL; return -EINVAL;
if (cmd->duplex == DUPLEX_FULL && if (cmd->base.duplex == DUPLEX_FULL &&
!(f & SUPPORTED_1000baseT_Full)) !(f & SUPPORTED_1000baseT_Full))
return -EINVAL; return -EINVAL;
break; break;
@ -2062,8 +2072,8 @@ static int emac_ethtool_set_settings(struct net_device *ndev,
} }
mutex_lock(&dev->link_lock); mutex_lock(&dev->link_lock);
dev->phy.def->ops->setup_forced(&dev->phy, cmd->speed, dev->phy.def->ops->setup_forced(&dev->phy, cmd->base.speed,
cmd->duplex); cmd->base.duplex);
mutex_unlock(&dev->link_lock); mutex_unlock(&dev->link_lock);
} else { } else {
@ -2072,7 +2082,7 @@ static int emac_ethtool_set_settings(struct net_device *ndev,
mutex_lock(&dev->link_lock); mutex_lock(&dev->link_lock);
dev->phy.def->ops->setup_aneg(&dev->phy, dev->phy.def->ops->setup_aneg(&dev->phy,
(cmd->advertising & f) | (advertising & f) |
(dev->phy.advertising & (dev->phy.advertising &
(ADVERTISED_Pause | (ADVERTISED_Pause |
ADVERTISED_Asym_Pause))); ADVERTISED_Asym_Pause)));
@ -2234,8 +2244,6 @@ static void emac_ethtool_get_drvinfo(struct net_device *ndev,
} }
static const struct ethtool_ops emac_ethtool_ops = { static const struct ethtool_ops emac_ethtool_ops = {
.get_settings = emac_ethtool_get_settings,
.set_settings = emac_ethtool_set_settings,
.get_drvinfo = emac_ethtool_get_drvinfo, .get_drvinfo = emac_ethtool_get_drvinfo,
.get_regs_len = emac_ethtool_get_regs_len, .get_regs_len = emac_ethtool_get_regs_len,
@ -2251,6 +2259,8 @@ static const struct ethtool_ops emac_ethtool_ops = {
.get_ethtool_stats = emac_ethtool_get_ethtool_stats, .get_ethtool_stats = emac_ethtool_get_ethtool_stats,
.get_link = ethtool_op_get_link, .get_link = ethtool_op_get_link,
.get_link_ksettings = emac_ethtool_get_link_ksettings,
.set_link_ksettings = emac_ethtool_set_link_ksettings,
}; };
static int emac_ioctl(struct net_device *ndev, struct ifreq *rq, int cmd) static int emac_ioctl(struct net_device *ndev, struct ifreq *rq, int cmd)