iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

blk-mq: simplify flush check in blk_mq_dispatch_rq_list

Browse Source 
1. Remove check of needs_resource and ret == BLK_STS_DEV_RESOURCE.
For busy error BLK_STS*_RESOURCE, request will always be added
back to list, so need_resource will not be true and ret will
not be == BLK_STS_DEV_RESOURCE if list is empty. We could remove
these dead check.

2. Check ret of last request instead of errors
If list is empty, we only need to explicitly commit_rqs
if error happens at last request which is stored in ret. So check
ret of last request instead of errors to remove unnecessary
commit_rqs triggered by errors returned from previous request.

Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Kemeng Shi
2023-01-18 17:37:22 +08:00
committed by Jens Axboe
parent 984ce0a7d7
commit e4ef2e05e0
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
block/blk-mq.c
View File

@ -2108,9 +2108,9 @@ out:
/* If we didn't flush the entire list, we could have told the driver /* If we didn't flush the entire list, we could have told the driver
* there was more coming, but that turned out to be a lie. * there was more coming, but that turned out to be a lie.
*/ */
if ((!list_empty(list) || errors || needs_resource || if (!list_empty(list) || ret != BLK_STS_OK)
ret == BLK_STS_DEV_RESOURCE) && q->mq_ops->commit_rqs && queued) blk_mq_commit_rqs(hctx, queued, false);
q->mq_ops->commit_rqs(hctx);
/* /*
* Any items that need requeuing? Stuff them into hctx->dispatch, * Any items that need requeuing? Stuff them into hctx->dispatch,
* that is where we will continue on next queue run. * that is where we will continue on next queue run.