iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pwm: Fix double shift bug

Browse Source 
[ Upstream commit d27abbfd48 ]

These enums are passed to set/test_bit().  The set/test_bit() functions
take a bit number instead of a shifted value.  Passing a shifted value
is a double shift bug like doing BIT(BIT(1)).  The double shift bug
doesn't cause a problem here because we are only checking 0 and 1 but
if the value was 5 or above then it can lead to a buffer overflow.

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Dan Carpenter
2023-10-25 14:58:18 +03:00
committed by Greg Kroah-Hartman
parent 53b2393eeb
commit e52518b9cb
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
include/linux/pwm.h
View File

@ -44,8 +44,8 @@ struct pwm_args {
}; };
enum { enum {
PWMF_REQUESTED = 1 << 0, PWMF_REQUESTED = 0,
PWMF_EXPORTED = 1 << 1, PWMF_EXPORTED = 1,
}; };
/* /*