iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

scsi: ufs: Disable local LCC in .link_startup_notify() in Cadence UFS

Browse Source 
Some UFS devices have issues if LCC is enabled. So we are setting
PA_LOCAL_TX_LCC_Enable to 0 before link startup which will make sure that
both host and device TX LCC are disabled once link startup is completed.

Signed-off-by: Anil Varughese <aniljoy@cadence.com>
Reviewed-by: Vignesh Raghavendra <vigneshr@ti.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Anil Varughese 2019-08-13 08:42:50 +01:00 committed by Martin K. Petersen
parent 5f6b4e1e09
commit e55f24ffa9
1 changed files with 27 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
drivers/scsi/ufs/cdns-pltfrm.c
View File

@ -77,6 +77,31 @@ static int cdns_ufs_hce_enable_notify(struct ufs_hba *hba,
return cdns_ufs_set_hclkdiv(hba); return cdns_ufs_set_hclkdiv(hba);
} }
/**
* Called before and after Link startup is carried out.
* @hba: host controller instance
* @status: notify stage (pre, post change)
*
* Return zero for success and non-zero for failure
*/
static int cdns_ufs_link_startup_notify(struct ufs_hba *hba,
enum ufs_notify_change_status status)
{
if (status != PRE_CHANGE)
return 0;
/*
* Some UFS devices have issues if LCC is enabled.
* So we are setting PA_Local_TX_LCC_Enable to 0
* before link startup which will make sure that both host
* and device TX LCC are disabled once link startup is
* completed.
*/
ufshcd_dme_set(hba, UIC_ARG_MIB(PA_LOCAL_TX_LCC_ENABLE), 0);
return 0;
}
/** /**
* cdns_ufs_init - performs additional ufs initialization * cdns_ufs_init - performs additional ufs initialization
* @hba: host controller instance * @hba: host controller instance
@ -114,12 +139,14 @@ static int cdns_ufs_m31_16nm_phy_initialization(struct ufs_hba *hba)
static const struct ufs_hba_variant_ops cdns_ufs_pltfm_hba_vops = { static const struct ufs_hba_variant_ops cdns_ufs_pltfm_hba_vops = {
.name = "cdns-ufs-pltfm", .name = "cdns-ufs-pltfm",
.hce_enable_notify = cdns_ufs_hce_enable_notify, .hce_enable_notify = cdns_ufs_hce_enable_notify,
.link_startup_notify = cdns_ufs_link_startup_notify,
}; };
static const struct ufs_hba_variant_ops cdns_ufs_m31_16nm_pltfm_hba_vops = { static const struct ufs_hba_variant_ops cdns_ufs_m31_16nm_pltfm_hba_vops = {
.name = "cdns-ufs-pltfm", .name = "cdns-ufs-pltfm",
.init = cdns_ufs_init, .init = cdns_ufs_init,
.hce_enable_notify = cdns_ufs_hce_enable_notify, .hce_enable_notify = cdns_ufs_hce_enable_notify,
.link_startup_notify = cdns_ufs_link_startup_notify,
.phy_initialization = cdns_ufs_m31_16nm_phy_initialization, .phy_initialization = cdns_ufs_m31_16nm_phy_initialization,
}; };