iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

regmap: mdio: Don't modify output if error happened

Browse Source 
regmap_mdio_read() breaks the principle of "no touch output till it's known
that the operation succeeds". Refactor it accordingly.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20210520120518.30490-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Andy Shevchenko 2021-05-20 15:05:18 +03:00 committed by Mark Brown
parent 9dee1f9fc5
commit e56360d6a1
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/base/regmap/regmap-mdio.c
View File

@ -11,9 +11,11 @@ static int regmap_mdio_read(void *context, unsigned int reg, unsigned int *val)
int ret;
ret = mdiobus_read(mdio_dev->bus, mdio_dev->addr, reg);
*val = ret & 0xffff;
if (ret < 0)
return ret;
return ret < 0 ? ret : 0;
*val = ret & 0xffff;
return 0;
}
static int regmap_mdio_write(void *context, unsigned int reg, unsigned int val)