iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

gfs2: Fix fall-through warnings for Clang

Browse Source 
In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
warnings by explicitly adding multiple goto statements instead of just
letting the code fall through to the next case.

Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
This commit is contained in:
Gustavo A. R. Silva 2020-11-20 12:25:03 -06:00 committed by Andreas Gruenbacher
parent c551f66c5d
commit e5966cf20f
2 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fs/gfs2/inode.c
View File

@ -963,6 +963,7 @@ static int gfs2_link(struct dentry *old_dentry, struct inode *dir,
break; break;
case 0: case 0:
error = -EEXIST; error = -EEXIST;
goto out_gunlock;
default: default:
goto out_gunlock; goto out_gunlock;
} }
@ -1508,6 +1509,7 @@ static int gfs2_rename(struct inode *odir, struct dentry *odentry,
break; break;
case 0: case 0:
error = -EEXIST; error = -EEXIST;
goto out_gunlock;
default: default:
goto out_gunlock; goto out_gunlock;
} }

1
fs/gfs2/recovery.c
View File

@ -438,6 +438,7 @@ void gfs2_recover_func(struct work_struct *work)
case GLR_TRYFAILED: case GLR_TRYFAILED:
fs_info(sdp, "jid=%u: Busy\n", jd->jd_jid); fs_info(sdp, "jid=%u: Busy\n", jd->jd_jid);
error = 0; error = 0;
goto fail;
default: default:
goto fail; goto fail;