iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

selftests: mqueue: return Kselftest Skip code for skipped tests

Browse Source 
When mqueue test is skipped because of unmet dependencies and/or
unsupported configuration, it exits with error which is treated as
a fail by the Kselftest framework. This leads to false negative
result even when the test could not be run.

Change it to return kselftest skip code when a test gets skipped to
clearly report that the test could not be run.

Change it to use ksft_exit_skip() when the test is skipped.

Signed-off-by: Shuah Khan (Samsung OSG) <shuah@kernel.org>
This commit is contained in:
Shuah Khan (Samsung OSG) 2018-05-04 14:26:10 -06:00
parent e1890c502c
commit e6ee6ae4a1
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tools/testing/selftests/mqueue/mq_open_tests.c
View File

@ -33,6 +33,8 @@
#include <mqueue.h>
#include <error.h>
#include "../kselftest.h"
static char *usage =
"Usage:\n"
" %s path\n"
@ -262,12 +264,10 @@ int main(int argc, char *argv[])
}
}
if (getuid() != 0) {
fprintf(stderr, "Not running as root, but almost all tests "
if (getuid() != 0)
ksft_exit_skip("Not running as root, but almost all tests "
"require root in order to modify\nsystem settings. "
"Exiting.\n");
exit(1);
}
/* Find out what files there are for us to make tweaks in */
def_msgs = fopen(DEF_MSGS, "r+");

8
tools/testing/selftests/mqueue/mq_perf_tests.c
View File

@ -39,6 +39,8 @@
#include <popt.h>
#include <error.h>
#include "../kselftest.h"
static char *usage =
"Usage:\n"
" %s [-c #[,#..] -f] path\n"
@ -626,12 +628,10 @@ int main(int argc, char *argv[])
cpus_to_pin[0] = cpus_online - 1;
}
if (getuid() != 0) {
fprintf(stderr, "Not running as root, but almost all tests "
if (getuid() != 0)
ksft_exit_skip("Not running as root, but almost all tests "
"require root in order to modify\nsystem settings. "
"Exiting.\n");
exit(1);
}
max_msgs = fopen(MAX_MSGS, "r+");
max_msgsize = fopen(MAX_MSGSIZE, "r+");