iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

firmware: qcom_scm: remove IS_ERR() checks from qcom_scm_bw_{en,dis}able()

Browse Source 
Since the qcom_scm_probe() function returns with an error if
__scm->path contains an error pointer, it is not needed to
verify that again in the qcom_scm_bw_{en,dis}able() functions
so remove the superfluous IS_ERR() checks.

Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Link: https://lore.kernel.org/r/20240308-qcom_scm-is_err-check-v1-1-9c3e1ceefafe@gmail.com
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
This commit is contained in:
Gabor Juhos 2024-03-08 10:25:07 +01:00 committed by Bjorn Andersson
parent 0c50b7fcf2
commit e6f3dac9cf
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/firmware/qcom/qcom_scm.c
View File

@ -163,9 +163,6 @@ static int qcom_scm_bw_enable(void)
if (!__scm->path)
return 0;
if (IS_ERR(__scm->path))
return -EINVAL;
mutex_lock(&__scm->scm_bw_lock);
if (!__scm->scm_vote_count) {
ret = icc_set_bw(__scm->path, 0, UINT_MAX);
@ -183,7 +180,7 @@ err_bw:
static void qcom_scm_bw_disable(void)
{
if (IS_ERR_OR_NULL(__scm->path))
if (!__scm->path)
return;
mutex_lock(&__scm->scm_bw_lock);