iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dccp/tcp: Remove an unused argument in inet_csk_listen_start().

Browse Source 
The commit 1295e2cf30 ("inet: minor optimization for backlog setting in
listen(2)") added change so that sk_max_ack_backlog is initialised earlier
in inet_dccp_listen() and inet_listen().  Since then, we no longer use
backlog in inet_csk_listen_start(), so let's remove it.

Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.co.jp>
Acked-by: Yafang Shao <laoar.shao@gmail.com>
Reviewed-by: Richard Sailer <richard_siegfried@systemli.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Kuniyuki Iwashima 2021-11-22 19:16:21 +09:00 committed by Jakub Kicinski
parent c6d5f19330
commit e7049395b1
5 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/net/inet_connection_sock.h
View File

@ -304,7 +304,7 @@ static inline __poll_t inet_csk_listen_poll(const struct sock *sk)
(EPOLLIN | EPOLLRDNORM) : 0; (EPOLLIN | EPOLLRDNORM) : 0;
} }
int inet_csk_listen_start(struct sock *sk, int backlog); int inet_csk_listen_start(struct sock *sk);
void inet_csk_listen_stop(struct sock *sk); void inet_csk_listen_stop(struct sock *sk);
void inet_csk_addr2sockaddr(struct sock *sk, struct sockaddr *uaddr); void inet_csk_addr2sockaddr(struct sock *sk, struct sockaddr *uaddr);

6
net/dccp/proto.c
View File

@ -238,7 +238,7 @@ void dccp_destroy_sock(struct sock *sk)
EXPORT_SYMBOL_GPL(dccp_destroy_sock); EXPORT_SYMBOL_GPL(dccp_destroy_sock);
static inline int dccp_listen_start(struct sock *sk, int backlog) static inline int dccp_listen_start(struct sock *sk)
{ {
struct dccp_sock *dp = dccp_sk(sk); struct dccp_sock *dp = dccp_sk(sk);
@ -246,7 +246,7 @@ static inline int dccp_listen_start(struct sock *sk, int backlog)
/* do not start to listen if feature negotiation setup fails */ /* do not start to listen if feature negotiation setup fails */
if (dccp_feat_finalise_settings(dp)) if (dccp_feat_finalise_settings(dp))
return -EPROTO; return -EPROTO;
return inet_csk_listen_start(sk, backlog); return inet_csk_listen_start(sk);
} }
static inline int dccp_need_reset(int state) static inline int dccp_need_reset(int state)
@ -935,7 +935,7 @@ int inet_dccp_listen(struct socket *sock, int backlog)
* FIXME: here it probably should be sk->sk_prot->listen_start * FIXME: here it probably should be sk->sk_prot->listen_start
* see tcp_listen_start * see tcp_listen_start
*/ */
err = dccp_listen_start(sk, backlog); err = dccp_listen_start(sk);
if (err) if (err)
goto out; goto out;
} }

2
net/ipv4/af_inet.c
View File

@ -225,7 +225,7 @@ int inet_listen(struct socket *sock, int backlog)
tcp_fastopen_init_key_once(sock_net(sk)); tcp_fastopen_init_key_once(sock_net(sk));
} }
err = inet_csk_listen_start(sk, backlog); err = inet_csk_listen_start(sk);
if (err) if (err)
goto out; goto out;
tcp_call_bpf(sk, BPF_SOCK_OPS_TCP_LISTEN_CB, 0, NULL); tcp_call_bpf(sk, BPF_SOCK_OPS_TCP_LISTEN_CB, 0, NULL);

2
net/ipv4/inet_connection_sock.c
View File

@ -1035,7 +1035,7 @@ void inet_csk_prepare_forced_close(struct sock *sk)
} }
EXPORT_SYMBOL(inet_csk_prepare_forced_close); EXPORT_SYMBOL(inet_csk_prepare_forced_close);
int inet_csk_listen_start(struct sock *sk, int backlog) int inet_csk_listen_start(struct sock *sk)
{ {
struct inet_connection_sock *icsk = inet_csk(sk); struct inet_connection_sock *icsk = inet_csk(sk);
struct inet_sock *inet = inet_sk(sk); struct inet_sock *inet = inet_sk(sk);

2
tools/testing/selftests/bpf/progs/test_sk_storage_tracing.c
View File

@ -68,7 +68,7 @@ static void set_task_info(struct sock *sk)
} }
SEC("fentry/inet_csk_listen_start") SEC("fentry/inet_csk_listen_start")
int BPF_PROG(trace_inet_csk_listen_start, struct sock *sk, int backlog) int BPF_PROG(trace_inet_csk_listen_start, struct sock *sk)
{ {
set_task_info(sk); set_task_info(sk);