iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

spi: dw: Fix error return code in dw_spi_bt1_probe()

Browse Source 
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: abf00907538e ("spi: dw: Add Baikal-T1 SPI Controller glue driver")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Acked-by: Serge Semin <fancer.lancer@gmail.com>
Link: https://lore.kernel.org/r/1607071357-33378-1-git-send-email-zhangchangzhong@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Zhang Changzhong 2020-12-04 16:42:37 +08:00 committed by Mark Brown
parent 2c2b3ad2c4
commit e748edd984
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/spi/spi-dw-bt1.c
View File

@ -280,8 +280,10 @@ static int dw_spi_bt1_probe(struct platform_device *pdev)
dws->bus_num = pdev->id; dws->bus_num = pdev->id;
dws->reg_io_width = 4; dws->reg_io_width = 4;
dws->max_freq = clk_get_rate(dwsbt1->clk); dws->max_freq = clk_get_rate(dwsbt1->clk);
if (!dws->max_freq) if (!dws->max_freq) {
ret = -EINVAL;
goto err_disable_clk; goto err_disable_clk;
}
init_func = device_get_match_data(&pdev->dev); init_func = device_get_match_data(&pdev->dev);
ret = init_func(pdev, dwsbt1); ret = init_func(pdev, dwsbt1);