iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

PCI/VPD: Change pci_vpd_init() return type to void

Browse Source 
pci_init_capabilities() is the only caller and doesn't use the return
value. So let's change the return type to void.

Link: https://lore.kernel.org/r/663ec440-8375-1459-ddb4-98ea76e75917@gmail.com
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
This commit is contained in:
Heiner Kallweit 2021-04-01 18:37:47 +02:00 committed by Bjorn Helgaas
parent d1df5f3f4c
commit e947e7b116
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/pci/pci.h
View File

@ -141,7 +141,7 @@ static inline bool pcie_downstream_port(const struct pci_dev *dev)
type == PCI_EXP_TYPE_PCIE_BRIDGE; type == PCI_EXP_TYPE_PCIE_BRIDGE;
} }
int pci_vpd_init(struct pci_dev *dev); void pci_vpd_init(struct pci_dev *dev);
void pci_vpd_release(struct pci_dev *dev); void pci_vpd_release(struct pci_dev *dev);
void pcie_vpd_create_sysfs_dev_files(struct pci_dev *dev); void pcie_vpd_create_sysfs_dev_files(struct pci_dev *dev);
void pcie_vpd_remove_sysfs_dev_files(struct pci_dev *dev); void pcie_vpd_remove_sysfs_dev_files(struct pci_dev *dev);

7
drivers/pci/vpd.c
View File

@ -327,18 +327,18 @@ static const struct pci_vpd_ops pci_vpd_f0_ops = {
.write = pci_vpd_f0_write, .write = pci_vpd_f0_write,
}; };
int pci_vpd_init(struct pci_dev *dev) void pci_vpd_init(struct pci_dev *dev)
{ {
struct pci_vpd *vpd; struct pci_vpd *vpd;
u8 cap; u8 cap;
cap = pci_find_capability(dev, PCI_CAP_ID_VPD); cap = pci_find_capability(dev, PCI_CAP_ID_VPD);
if (!cap) if (!cap)
return -ENODEV; return;
vpd = kzalloc(sizeof(*vpd), GFP_ATOMIC); vpd = kzalloc(sizeof(*vpd), GFP_ATOMIC);
if (!vpd) if (!vpd)
return -ENOMEM; return;
vpd->len = PCI_VPD_MAX_SIZE; vpd->len = PCI_VPD_MAX_SIZE;
if (dev->dev_flags & PCI_DEV_FLAGS_VPD_REF_F0) if (dev->dev_flags & PCI_DEV_FLAGS_VPD_REF_F0)
@ -350,7 +350,6 @@ int pci_vpd_init(struct pci_dev *dev)
vpd->busy = 0; vpd->busy = 0;
vpd->valid = 0; vpd->valid = 0;
dev->vpd = vpd; dev->vpd = vpd;
return 0;
} }
void pci_vpd_release(struct pci_dev *dev) void pci_vpd_release(struct pci_dev *dev)