iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[media] tlg2300: fix up check_firmware() return

Browse Source 
The caller doesn't check the return value of check_firmware() but static
checkers complain.  It currently returns negative error codes, or zero
or greater on success but since the return type is boolean the values
are truncated to one or zero.  I've changed it to return an int,
negative on error and zero on success.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Dan Carpenter 2012-01-15 07:32:19 -03:00 committed by Mauro Carvalho Chehab
parent 0397e45059
commit e9ae4d4f02
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/media/video/tlg2300/pd-main.c
View File

@ -374,7 +374,7 @@ static inline void set_map_flags(struct poseidon *pd, struct usb_device *udev)
}
#endif
static bool check_firmware(struct usb_device *udev, int *down_firmware)
static int check_firmware(struct usb_device *udev, int *down_firmware)
{
void *buf;
int ret;
@ -398,7 +398,7 @@ static bool check_firmware(struct usb_device *udev, int *down_firmware)
*down_firmware = 1;
return firmware_download(udev);
}
return ret;
return 0;
}
static int poseidon_probe(struct usb_interface *interface,