iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

lightnvm: refactor spin_unlock in gennvm_get_blk

Browse Source 
The spin_unlock is duplicated multiple times. Jump to a single unlock
to improve the code flow.

Signed-off-by: Wenwei Tao <ww.tao0320@gmail.com>
Signed-off-by: Matias Bjørling <m@bjorling.me>
Signed-off-by: Jens Axboe <axboe@fb.com>
This commit is contained in:
Wenwei Tao
2015-12-06 11:25:45 +01:00
committed by Jens Axboe
parent d3d1a43842
commit e9b76a80f1
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/lightnvm/gennvm.c
View File

@@ -262,14 +262,11 @@ static struct nvm_block *gennvm_get_blk(struct nvm_dev *dev,
if (list_empty(&lun->free_list)) { if (list_empty(&lun->free_list)) {
pr_err_ratelimited("gennvm: lun %u have no free pages available", pr_err_ratelimited("gennvm: lun %u have no free pages available",
lun->vlun.id); lun->vlun.id);
spin_unlock(&vlun->lock);
goto out; goto out;
} }
while (!is_gc && lun->vlun.nr_free_blocks < lun->reserved_blocks) { if (!is_gc && lun->vlun.nr_free_blocks < lun->reserved_blocks)
spin_unlock(&vlun->lock);
goto out; goto out;
}
blk = list_first_entry(&lun->free_list, struct nvm_block, list); blk = list_first_entry(&lun->free_list, struct nvm_block, list);
list_move_tail(&blk->list, &lun->used_list); list_move_tail(&blk->list, &lun->used_list);
@@ -278,8 +275,8 @@ static struct nvm_block *gennvm_get_blk(struct nvm_dev *dev,
lun->vlun.nr_free_blocks--; lun->vlun.nr_free_blocks--;
lun->vlun.nr_inuse_blocks++; lun->vlun.nr_inuse_blocks++;
spin_unlock(&vlun->lock);
out: out:
spin_unlock(&vlun->lock);
return blk; return blk;
} }