iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

staging: comedi: s626.c - fix multiline dereference

Browse Source 
staging: comedi: s626.c - fix the following checkpatch issues:
WARNING: Avoid multiple line dereference - prefer 'devpriv->rps_buf.logical_base'
#1380: FILE: drivers/s626.c:1380:
+				   (unsigned long)devpriv->
+						  rps_buf.logical_base);

WARNING: Avoid multiple line dereference - prefer 'cmd->scan_begin_arg'
#1898: FILE: drivers/s626.c:1898:
+			err |= comedi_check_trigger_arg_min(&cmd->
+							    scan_begin_arg,

Signed-off-by: Roman Lakeev <sunnyddayss@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Roman Lakeev 2017-12-13 20:39:53 -08:00 committed by Greg Kroah-Hartman
parent 07df5b7c94
commit e9f14f1954
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/staging/comedi/drivers/s626.c
View File

@ -1376,8 +1376,7 @@ static void s626_reset_adc(struct comedi_device *dev, u8 *ppl)
jmp_adrs =
(u32)devpriv->rps_buf.physical_base +
(u32)((unsigned long)rps -
(unsigned long)devpriv->
rps_buf.logical_base);
(unsigned long)devpriv->rps_buf.logical_base);
for (i = 0; i < (10 * S626_RPSCLK_PER_US / 2); i++) {
jmp_adrs += 8; /* Repeat to implement time delay: */
/* Jump to next RPS instruction. */
@ -1894,9 +1893,9 @@ static int s626_ai_cmdtest(struct comedi_device *dev,
if (cmd->scan_begin_src == TRIG_TIMER) {
arg = cmd->convert_arg * cmd->scan_end_arg;
err |= comedi_check_trigger_arg_min(&cmd->
scan_begin_arg,
arg);
err |= comedi_check_trigger_arg_min(
&cmd->scan_begin_arg,
arg);
}
}