iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

scsi/core: Improve static type checking

Browse Source 
Improve static type checking by using the new blk_opf_t type for the
combination of a request operation and its flags.

Cc: Martin K. Petersen <martin.petersen@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Ming Lei <ming.lei@redhat.com>
Cc: Hannes Reinecke <hare@suse.de>
Cc: John Garry <john.garry@huawei.com>
Cc: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20220714180729.1065367-40-bvanassche@acm.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Bart Van Assche 2022-07-14 11:07:05 -07:00 committed by Jens Axboe
parent a288000f9f
commit ea957547e8
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/scsi/scsi_lib.c
View File

@ -1125,12 +1125,12 @@ static void scsi_initialize_rq(struct request *rq)
cmd->retries = 0; cmd->retries = 0;
} }
struct request *scsi_alloc_request(struct request_queue *q, struct request *scsi_alloc_request(struct request_queue *q, blk_opf_t opf,
unsigned int op, blk_mq_req_flags_t flags) blk_mq_req_flags_t flags)
{ {
struct request *rq; struct request *rq;
rq = blk_mq_alloc_request(q, op, flags); rq = blk_mq_alloc_request(q, opf, flags);
if (!IS_ERR(rq)) if (!IS_ERR(rq))
scsi_initialize_rq(rq); scsi_initialize_rq(rq);
return rq; return rq;

4
include/scsi/scsi_cmnd.h
View File

@ -386,7 +386,7 @@ static inline unsigned scsi_transfer_length(struct scsi_cmnd *scmd)
extern void scsi_build_sense(struct scsi_cmnd *scmd, int desc, extern void scsi_build_sense(struct scsi_cmnd *scmd, int desc,
u8 key, u8 asc, u8 ascq); u8 key, u8 asc, u8 ascq);
struct request *scsi_alloc_request(struct request_queue *q, struct request *scsi_alloc_request(struct request_queue *q, blk_opf_t opf,
unsigned int op, blk_mq_req_flags_t flags); blk_mq_req_flags_t flags);
#endif /* _SCSI_SCSI_CMND_H */ #endif /* _SCSI_SCSI_CMND_H */