iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drm/amd/display: handler not correctly checked at remove_irq_handler

Browse Source 
[why]
handler is supposedly passed in as a function pointer;
however, the entire struct amdgpu_dm_irq_handler_data
gets from the list is used to check match.

[how]
use the interrupt_handler within amdgpu_dm_irq_handler_data
for checking match.

Signed-off-by: Qingqing Zhuo <qingqing.zhuo@amd.com>
Acked-by: Bindu Ramamurthy <bindu.r@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
This commit is contained in:
Qingqing Zhuo 2020-12-04 10:55:13 -05:00 committed by Alex Deucher
parent 462fbeb1fc
commit ea96b12aa4
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c
View File

@ -165,7 +165,10 @@ static struct list_head *remove_irq_handler(struct amdgpu_device *adev,
handler = list_entry(entry, struct amdgpu_dm_irq_handler_data, handler = list_entry(entry, struct amdgpu_dm_irq_handler_data,
list); list);
if (ih == handler) { if (handler == NULL)
continue;
if (ih == handler->handler) {
/* Found our handler. Remove it from the list. */ /* Found our handler. Remove it from the list. */
list_del(&handler->list); list_del(&handler->list);
handler_removed = true; handler_removed = true;