nexthop: Unlink nexthop group entry in error path

[ Upstream commit 7b01e53eee ]

In case of error, remove the nexthop group entry from the list to which
it was previously added.

Fixes: 430a049190 ("nexthop: Add support for nexthop groups")
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: Petr Machata <petrm@nvidia.com>
Reviewed-by: David Ahern <dsahern@kernel.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Ido Schimmel
2021-01-07 16:48:22 +02:00
committed by Greg Kroah-Hartman
parent 6486bc0a34
commit eaa7a6c39d

View File

@ -1277,8 +1277,10 @@ static struct nexthop *nexthop_create_group(struct net *net,
return nh; return nh;
out_no_nh: out_no_nh:
for (i--; i >= 0; --i) for (i--; i >= 0; --i) {
list_del(&nhg->nh_entries[i].nh_list);
nexthop_put(nhg->nh_entries[i].nh); nexthop_put(nhg->nh_entries[i].nh);
}
kfree(nhg->spare); kfree(nhg->spare);
kfree(nhg); kfree(nhg);