iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fbdev: pxafb: Convert to platform remove callback returning void

Browse Source 
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Helge Deller <deller@gmx.de>
This commit is contained in:
Uwe Kleine-König 2023-03-19 00:54:12 +01:00 committed by Helge Deller
parent 2872c2913a
commit eb703b6089
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/video/fbdev/pxafb.c
View File

@ -2396,13 +2396,13 @@ failed:
return ret; return ret;
} }
static int pxafb_remove(struct platform_device *dev) static void pxafb_remove(struct platform_device *dev)
{ {
struct pxafb_info *fbi = platform_get_drvdata(dev); struct pxafb_info *fbi = platform_get_drvdata(dev);
struct fb_info *info; struct fb_info *info;
if (!fbi) if (!fbi)
return 0; return;
info = &fbi->fb; info = &fbi->fb;
@ -2418,8 +2418,6 @@ static int pxafb_remove(struct platform_device *dev)
dma_free_coherent(&dev->dev, fbi->dma_buff_size, fbi->dma_buff, dma_free_coherent(&dev->dev, fbi->dma_buff_size, fbi->dma_buff,
fbi->dma_buff_phys); fbi->dma_buff_phys);
return 0;
} }
static const struct of_device_id pxafb_of_dev_id[] = { static const struct of_device_id pxafb_of_dev_id[] = {
@ -2432,7 +2430,7 @@ MODULE_DEVICE_TABLE(of, pxafb_of_dev_id);
static struct platform_driver pxafb_driver = { static struct platform_driver pxafb_driver = {
.probe = pxafb_probe, .probe = pxafb_probe,
.remove = pxafb_remove, .remove_new = pxafb_remove,
.driver = { .driver = {
.name = "pxa2xx-fb", .name = "pxa2xx-fb",
.of_match_table = pxafb_of_dev_id, .of_match_table = pxafb_of_dev_id,