iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

block: cfq_cpd_alloc() should use @gfp

Browse Source 
cfq_cpd_alloc() which is the cpd_alloc_fn implementation for cfq was
incorrectly hard coding GFP_KERNEL instead of using the mask specified
through the @gfp parameter.  This currently doesn't cause any actual
issues because all current callers specify GFP_KERNEL.  Fix it.

Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: e4a9bde9589f ("blkcg: replace blkcg_policy->cpd_size with ->cpd_alloc/free_fn() methods")
Signed-off-by: Jens Axboe <axboe@fb.com>
This commit is contained in:
Tejun Heo 2016-11-10 11:16:37 -05:00 committed by Jens Axboe
parent 7bf58533a0
commit ebc4ff661f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
block/cfq-iosched.c
View File

@ -1586,7 +1586,7 @@ static struct blkcg_policy_data *cfq_cpd_alloc(gfp_t gfp)
{ {
struct cfq_group_data *cgd; struct cfq_group_data *cgd;
cgd = kzalloc(sizeof(*cgd), GFP_KERNEL); cgd = kzalloc(sizeof(*cgd), gfp);
if (!cgd) if (!cgd)
return NULL; return NULL;
return &cgd->cpd; return &cgd->cpd;