drm/rockchip: lvds: add missing of_node_put
The device node iterators perform an of_node_get on each iteration, so a jump out of the loop requires an of_node_put. The semantic patch that fixes this problem is as follows (http://coccinelle.lip6.fr): // <smpl> @@ expression root,e; local idexpression child; iterator name for_each_child_of_node; @@ for_each_child_of_node(root, child) { ... when != of_node_put(child) when != e = child + of_node_put(child); ? break; ... } ... when != child // </smpl> Fixes: 34cc0aa25456 ("drm/rockchip: Add support for Rockchip Soc LVDS") Cc: stable@vger.kernel.org Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Heiko Stuebner <heiko@sntech.de> Link: https://patchwork.freedesktop.org/patch/msgid/1527102436-13447-6-git-send-email-Julia.Lawall@lip6.fr
This commit is contained in:
parent
e89ea35596
commit
ebfb081edc
@ -363,8 +363,10 @@ static int rockchip_lvds_bind(struct device *dev, struct device *master,
|
||||
of_property_read_u32(endpoint, "reg", &endpoint_id);
|
||||
ret = drm_of_find_panel_or_bridge(dev->of_node, 1, endpoint_id,
|
||||
&lvds->panel, &lvds->bridge);
|
||||
if (!ret)
|
||||
if (!ret) {
|
||||
of_node_put(endpoint);
|
||||
break;
|
||||
}
|
||||
}
|
||||
if (!child_count) {
|
||||
DRM_DEV_ERROR(dev, "lvds port does not have any children\n");
|
||||
|
Loading…
x
Reference in New Issue
Block a user