iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

of: add consistency check to of_node_release()

Browse Source 
Add an additional consistency check to of_node_release(), which is
called when the reference count of a devicetree node is decremented
to zero.  The node's children should have been deleted before the
node is deleted so check that no children exist.

Signed-off-by: Frank Rowand <frowand.list@gmail.com>
Link: https://lore.kernel.org/r/20230213185702.395776-7-frowand.list@gmail.com
Signed-off-by: Rob Herring <robh@kernel.org>
This commit is contained in:
Frank Rowand 2023-02-13 12:57:01 -06:00 committed by Rob Herring
parent 23522dd703
commit ec0b7e24d5
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/of/dynamic.c
View File

@ -377,6 +377,10 @@ void of_node_release(struct kobject *kobj)
__func__, node); __func__, node);
} }
if (node->child)
pr_err("ERROR: %s() unexpected children for %pOF/%s\n",
__func__, node->parent, node->full_name);
property_list_free(node->properties); property_list_free(node->properties);
property_list_free(node->deadprops); property_list_free(node->deadprops);
fwnode_links_purge(of_fwnode_handle(node)); fwnode_links_purge(of_fwnode_handle(node));