iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

scsi: st: remove unneeded variable 'result' in st_release()

Browse Source 
Also remove a strange '^L' after this function.

Fix the following coccicheck warning:

drivers/scsi/st.c:1460:5-11: Unneeded variable: "result". Return "0" on
line 1473

Link: https://lore.kernel.org/r/20200418070605.11450-1-yanaijie@huawei.com
Reported-by: Hulk Robot <hulkci@huawei.com>
Acked-by: Kai Mäkisara <kai.makisara@kolumbus.fi>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Jason Yan 2020-04-18 15:06:05 +08:00 committed by Martin K. Petersen
parent 7109cb5151
commit ec34143912
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/scsi/st.c
View File

@ -1457,7 +1457,6 @@ static int st_flush(struct file *filp, fl_owner_t id)
accessing this tape. */ accessing this tape. */
static int st_release(struct inode *inode, struct file *filp) static int st_release(struct inode *inode, struct file *filp)
{ {
int result = 0;
struct scsi_tape *STp = filp->private_data; struct scsi_tape *STp = filp->private_data;
if (STp->door_locked == ST_LOCKED_AUTO) if (STp->door_locked == ST_LOCKED_AUTO)
@ -1470,9 +1469,9 @@ static int st_release(struct inode *inode, struct file *filp)
scsi_autopm_put_device(STp->device); scsi_autopm_put_device(STp->device);
scsi_tape_put(STp); scsi_tape_put(STp);
return result; return 0;
} }
/* The checks common to both reading and writing */ /* The checks common to both reading and writing */
static ssize_t rw_checks(struct scsi_tape *STp, struct file *filp, size_t count) static ssize_t rw_checks(struct scsi_tape *STp, struct file *filp, size_t count)
{ {