iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

neighbour: fix unaligned access to pneigh_entry

Browse Source 
After the blamed commit, the member key is longer 4-byte aligned. On
platforms that do not support unaligned access, e.g., MIPS32R2 with
unaligned_action set to 1, this will trigger a crash when accessing
an IPv6 pneigh_entry, as the key is cast to an in6_addr pointer.

Change the type of the key to u32 to make it aligned.

Fixes: 62dd93181a ("[IPV6] NDISC: Set per-entry is_router flag in Proxy NA.")
Signed-off-by: Qingfang DENG <qingfang.deng@siflower.com.cn>
Link: https://lore.kernel.org/r/20230601015432.159066-1-dqfext@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Qingfang DENG 2023-06-01 09:54:32 +08:00 committed by Jakub Kicinski
parent 714069daa5
commit ed779fe4c9
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/net/neighbour.h
View File

@ -180,7 +180,7 @@ struct pneigh_entry {
netdevice_tracker dev_tracker; netdevice_tracker dev_tracker;
u32 flags; u32 flags;
u8 protocol; u8 protocol;
u8 key[]; u32 key[];
}; };
/* /*