iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

clocksource/drivers/timer-stm32-lp: Mark driver as non-removable

Browse Source 
The comment in the remove callback suggests that the driver is not
supposed to be unbound. However returning an error code in the remove
callback doesn't accomplish that. Instead set the suppress_bind_attrs
property (which makes it impossible to unbind the driver via sysfs).
The only remaining way to unbind an stm32-lp device would be module
unloading, but that doesn't apply here, as the driver cannot be built as
a module.

Also drop the useless remove callback.

[dlezcano] : Fixed up the wrong function removed

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20230313075430.2730803-3-u.kleine-koenig@pengutronix.de
This commit is contained in:
Uwe Kleine-König 2023-03-13 08:54:27 +01:00 committed by Daniel Lezcano
parent 78012e3880
commit ede38f924a
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/clocksource/timer-stm32-lp.c
View File

@ -195,11 +195,6 @@ out_clk_disable:
return ret; return ret;
} }
static int stm32_clkevent_lp_remove(struct platform_device *pdev)
{
return -EBUSY; /* cannot unregister clockevent */
}
static const struct of_device_id stm32_clkevent_lp_of_match[] = { static const struct of_device_id stm32_clkevent_lp_of_match[] = {
{ .compatible = "st,stm32-lptimer-timer", }, { .compatible = "st,stm32-lptimer-timer", },
{}, {},
@ -207,11 +202,11 @@ static const struct of_device_id stm32_clkevent_lp_of_match[] = {
MODULE_DEVICE_TABLE(of, stm32_clkevent_lp_of_match); MODULE_DEVICE_TABLE(of, stm32_clkevent_lp_of_match);
static struct platform_driver stm32_clkevent_lp_driver = { static struct platform_driver stm32_clkevent_lp_driver = {
.probe = stm32_clkevent_lp_probe, .probe = stm32_clkevent_lp_probe,
.remove = stm32_clkevent_lp_remove,
.driver = { .driver = {
.name = "stm32-lptimer-timer", .name = "stm32-lptimer-timer",
.of_match_table = of_match_ptr(stm32_clkevent_lp_of_match), .of_match_table = of_match_ptr(stm32_clkevent_lp_of_match),
.suppress_bind_attrs = true,
}, },
}; };
module_platform_driver(stm32_clkevent_lp_driver); module_platform_driver(stm32_clkevent_lp_driver);